What You Should Look Out For When You Review Pull Request

Meng Taing
11 min readNov 18, 2019
Photo by Simon English on Unsplash

You just graduated with Computer Science degree and started your first job as junior developer. Thanks to your final year project, you equipped yourself with some coding experience which landed you in this job.

After a few days of honey moon period of onboarding, you are added to company enterprise Github. You know what Github is because it’s where pushed your final year project source code. You’re assigned to you first project with a few members working in the same code base. Coding starts.

A few hours later, you received email from GitHub. Someone in your team is requesting your review on his pull request. You don’t even know what pull request is or how to review it.

Photo by Paul Hanaoka on Unsplash

This story will briefly explain what pull request is and why it is important. If you’re already familiar with the definition, skip to the main point, which is the 9 questions you should ask yourself when reviewing a pull request.

What is Pull Request?

Pull requests let you tell others about changes you’ve pushed to a branch in a repository on GitHub. Once a pull request is opened, you can discuss and review the potential changes with collaborators and add follow-up commits before your changes are merged into the base branch. About pull requests – GitHub Help

Pull request (hereinafter referred to as PR) is how you tell others about the changes you want to merge from your branch to master branch or develop branch.

airbnb / enzyme pull request page

The person who creates PR is called author. Author can request one or multiple people to review his PR. Those people are known as reviewers. Reviewer can be the engineer lead in the team, the project members, or anyone in the organization. Anyone can review a PR as long as enough context is given.

PR shows changes in the files which have been modified by the author. Reviewers gives comments on certain line of code when they find…

--

--

Meng Taing

Fullstack developer. When life gives you a lemon, write a script to turn it into lemonade so that you don’t have to deal with it again.